Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with native css/sass/scss in Next.js 9.3+ #31

Closed
tomdohnal opened this issue Mar 23, 2020 · 5 comments
Closed

Breaks with native css/sass/scss in Next.js 9.3+ #31

tomdohnal opened this issue Mar 23, 2020 · 5 comments

Comments

@tomdohnal
Copy link

tomdohnal commented Mar 23, 2020

Next.js now imports images from css/sass/scss file by itself and we use next-images package together with it, it breaks the native image import in css/sass/scss functionality.

As suggested in this issue, the solution is to check the issuer in the webpack rule specification.

I can create a PR with the fix if you're interested.

@arefaslani
Copy link
Member

arefaslani commented Mar 23, 2020

Thanks @tomdohnal for reporting this issue. I'll fix that today and will release a new patch for that.

@stegano
Copy link

stegano commented Mar 28, 2020

Hope this issue will be resolved quickly

@arefaslani
Copy link
Member

@tomdohnal @stegano This issue is fixed now. I'm really sorry, I had two projects to work on and it took me some time to come back to this repo and fix this issue.

@stegano
Copy link

stegano commented Mar 28, 2020

Thanks for fixing this issue 👍 It works!

@tomdohnal
Copy link
Author

@tomdohnal @stegano This issue is fixed now. I'm really sorry, I had two projects to work on and it took me some time to come back to this repo and fix this issue.

No worries at all :) Thank you for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants