Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prune armory legacy dead code in aid of charmory namespace fusion #38

Closed
1 task done
mwartell opened this issue Nov 2, 2023 · 1 comment · Fixed by #85
Closed
1 task done

prune armory legacy dead code in aid of charmory namespace fusion #38

mwartell opened this issue Nov 2, 2023 · 1 comment · Fixed by #85
Assignees
@Honaker

Comments

@mwartell
Copy link
Contributor

mwartell commented Nov 2, 2023 •
edited
Loading

There are big chunks of code in armory. which should go away. There are also latent capacities in the legacy code which should be preserved (Scenario and Metrics, etc.)

Per Treubig, we might just want to ditch latent bits and let Git remember stuff for us.

  • replace street-art Charmory logo with Armory logo
@mwartell
Copy link
Contributor Author

mwartell commented Dec 6, 2023

PR #66 partially fulfilled this

@mwartell mwartell linked a pull request Dec 13, 2023 that will close this issue
delete almost everything from src/armory #85
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Honaker Honaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delete almost everything from src/armory twosixlabs/armory-library
2 participants
@mwartell @Honaker