feat(traverse): Provide access to original Datum hash #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhrpr
reviewed
Sep 13, 2022
| pub vkeywitness: Option<Vec<VKeyWitness>>, | ||
|
|
||
| #[n(1)] | ||
| pub native_script: Option<Vec<NativeScript>>, |
There was a problem hiding this comment.
Should we use KeepRaw for NativeScript? When we decode a NativeScript into an internal representation we decode both definite and indefinite arrays, but we encode to definite. The hash needs to match the original bytes so that the script hash matches addresses in the inputs.
There was a problem hiding this comment.
yes, there are lot of sub-structures that will need this treatment. Off the top of my head, redeemers and metadata. I would prefer to treat each one on a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.