Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Windows Socket Connections #279

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

OlofBlomqvist
Copy link
Contributor

This PR adds a platform specific connect method to the NodeClient so that it can connect to cardano nodes via named pipes on Windows.

Client setup as usual:

let mut client = 
  pallas_network::facades::NodeClient::connect(
      r#"\\.\pipe\cardano-node-preprod"#, 
      self.configuration.magic
  ).await

Run node with named pipe:

cardano-node.exe run ....... --socket-path "\\.\pipe\cardano-node-preprod"

@OlofBlomqvist OlofBlomqvist marked this pull request as ready for review August 14, 2023 13:02
scarmuega
scarmuega previously approved these changes Sep 1, 2023
@scarmuega
Copy link
Member

@OlofBlomqvist looks good! if you don't mind fixing the merge conflict on your side, I think we're good to go.

@OlofBlomqvist
Copy link
Contributor Author

OlofBlomqvist commented Sep 1, 2023

@scarmuega - Merged! Should probably make another PR for adding named pipes support also to the newly merged server side parts at some point.

btw - the merge reset your review in case you didnt notice

@scarmuega scarmuega merged commit d6bcffe into txpipe:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants