Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: partial fix local tx submission, move RejectReason out of Error #306

Merged
merged 6 commits into from
Jun 29, 2024

Conversation

teebaumcrypto
Copy link
Contributor

The erorr should not mix a rust error with a protocol error.

@teebaumcrypto
Copy link
Contributor Author

cbor is skipped if it's a rejection, i think decoder of rejectionreason somehow doesn't return it correctly to the decoder, that it only removes an array and the label from the self.temp value, rather than the whole cbor.
this "hack" fixes it. so the self.temp value gets cleared in the channel.

@teebaumcrypto
Copy link
Contributor Author

if the node rejects a tx with an error from a plutus script, it sends directly the reason, therefore if the first element isn't an array, we expect it to be a rejection.

kalomaaan added a commit to kalomaaan/pallas that referenced this pull request Jan 22, 2024
@scarmuega scarmuega merged commit 1adc9a3 into txpipe:main Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants