chore: Merge mini-protocols into single crate #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavlix maybe you can have a look, may give some insight when rewriting our Ouroboros networking libs for Tokio.... |
Actually never mind, all issues seems totally out of scope for the networking part, and are related to either |
Fix links to individual mini-protocols within `pallas-machines` crate...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29
The goal is to have the following network-related crates:
The argument against merging the two crates into a potential "pallas-network" is that it would be an artificial coupling not really required at the code level. Multiplexing is agnostic of the mini-protocols (even agnostic of the cbor encoding). Having it as different crates would allow easier repurposing of either crate.