Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optionally overlap WAL with immutable part of chain when pruning #419

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat: optionally overlap WAL with immutable part of chain when pruning #419

merged 2 commits into from
Mar 8, 2024

Conversation

jmhrpr
Copy link
Member

@jmhrpr jmhrpr commented Mar 6, 2024 •
edited
Loading

@jmhrpr jmhrpr requested a review from scarmuega March 6, 2024 10:17
@scarmuega
Copy link
Member

@jmhrpr looks good! could we add a unit test to cover the overlap logic?

something like:

  • create dummy data
  • run purge
  • make sure that overlap exists and has correct size

@scarmuega scarmuega merged commit 87ff44b into txpipe:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarmuega scarmuega scarmuega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmhrpr @scarmuega