Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): Improve ergonomics for Byron primitives #47

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

scarmuega
Copy link
Member

No description provided.

@scarmuega scarmuega marked this pull request as ready for review February 12, 2022 22:37
Copy link
Collaborator

@mark-stopka mark-stopka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-stopka
Copy link
Collaborator

I don't know if it is necessarily something we want to test for, but @NicolasDP told me, that there are some JPEGs encoded in some Byron addresses, so maybe we should find some of those early "NFTs" when we will be adding the next wave of blocks for tests =)

@mark-stopka mark-stopka merged commit c3662e1 into main Feb 12, 2022
@mark-stopka mark-stopka added the enhancement New feature or request label Feb 12, 2022
@mark-stopka mark-stopka deleted the feat/byron-extend branch February 12, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants