Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplify ChainSync agent logic #48

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Conversation

scarmuega
Copy link
Member

Instead of forcing the consumer agent to extract a cursor from the payload, we just pass the bytes to the observer. In this way, implementors can decide when / how to execute the decoding.

Bonus: we now pass the tip of the chain to the observer (needed for Oura).

@scarmuega scarmuega added the enhancement New feature or request label Feb 14, 2022
@scarmuega scarmuega self-assigned this Feb 14, 2022
@scarmuega scarmuega marked this pull request as ready for review February 14, 2022 21:29
@scarmuega scarmuega merged commit 630d53d into main Feb 14, 2022
@scarmuega scarmuega deleted the feat/simpler-chainsync branch February 14, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant