Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors not accurate when converting colors from hsl > rgb when calling triadic and tetradic functions #1

Open
tylerguy opened this issue Mar 1, 2024 · 1 comment
Assignees

Comments

@tylerguy
Copy link
Owner

tylerguy commented Mar 1, 2024

When converting from a HSL to RGB color whenever getTriadicColor and getTetradicColor are called, rgb values end up being either 1 higher or lower.

@tylerguy tylerguy self-assigned this Mar 1, 2024
@tylerguy
Copy link
Owner Author

tylerguy commented Mar 1, 2024

Few test cases to check
#ec0ffd - should return [ 253, 236, 15 ], [ 15, 253, 236 ], but returns [ 253, 237, 15 ], [ 15, 253, 237 ]
#ec0ffe - should return [ 254, 236, 15 ], [ 15, 254, 236 ] but returns [ 254, 234, 15 ], [ 15, 254, 234 ] (this is more of a difference than previously observed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant