Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Tests fail with Go 1.10 #106

Open
stapelberg opened this issue Feb 16, 2018 · 1 comment
Open

Tests fail with Go 1.10 #106

stapelberg opened this issue Feb 16, 2018 · 1 comment

Comments

@stapelberg
Copy link

% go test gopkg.in/tylerb/graceful.v1/...
--- FAIL: TestGracefulForwardsConnState (0.25s)
	graceful_test.go:328: Incorrect connection state tracking.
		  actual: map[new:8 active:8]
		expected: map[new:8 active:8 closed:8]
2018/02/16 18:36:03 http: TLS handshake error from [::1]:45106: remote error: tls: bad certificate
--- FAIL: TestHTTP2ListenAndServeTLS (0.10s)
	http2_test.go:48: Error encountered while connecting to test server: Get https://localhost:9654: tls: failed to parse certificate from server: x509: cannot parse dnsName "Test Intermediate CA"
2018/02/16 18:36:04 http: TLS handshake error from [::1]:45108: remote error: tls: bad certificate
--- FAIL: TestHTTP2ListenAndServeTLSConfig (0.10s)
	http2_test.go:48: Error encountered while connecting to test server: Get https://localhost:9654: tls: failed to parse certificate from server: x509: cannot parse dnsName "Test Intermediate CA"
FAIL
FAIL	gopkg.in/tylerb/graceful.v1	4.665s
?   	gopkg.in/tylerb/graceful.v1/tests	[no test files]

I think the test-fixtures/* files need to be re-generated with a name that can be parsed.

Thanks!

@stapelberg
Copy link
Author

Or perhaps we should just switch to https://golang.org/pkg/net/http/httptest/#NewTLSServer instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant