Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the typings from this repo be moved over to the actual node-amqp10 repo? #3

Open
amarzavery opened this issue Jan 24, 2018 · 4 comments

Comments

@amarzavery
Copy link

@michaelinipop, @SomaticIT - Can the typings from this repo be moved over to the actual node-amqp10 repo?
In that way we can have "types" property in package.json and ship typings along with the package.
What do you guys think?

@iandvt
Copy link

iandvt commented Jan 29, 2018

+1 this would be awesome.

@SomaticIT
Copy link
Contributor

Of course, this work can be merged inside the core node-amqp10 project.
Please contact the project owner to know if he is interested in this merge?

Thank

@lostfields
Copy link

lostfields commented Feb 13, 2018

if that isn't possible, why not include it in npm @types/amqp10 ?

https://www.npmjs.com/search?q=%40types

@SomaticIT
Copy link
Contributor

I tried but do not have the rights on the @types namespace.
Maybe should we merge with the definitely typed repo which is responsible for the @types namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants