Skip to content

Commit 178dae7

Browse files
committed
Bump node from 10.x to 12.x
Also use pinned volta versions in CI.
1 parent 10515cb commit 178dae7

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,7 @@ jobs:
2626
steps:
2727
- name: Checkout Code
2828
uses: actions/checkout@v2
29-
- name: Install Node
30-
uses: actions/setup-node@v1
31-
with:
32-
node-version: '^10'
29+
- uses: volta-cli/action@v1
3330
# https://github.com/expo/expo-github-action/issues/20#issuecomment-541676895
3431
- name: Raise Watched File Limit
3532
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
@@ -53,7 +50,7 @@ jobs:
5350
- name: Install Node
5451
uses: actions/setup-node@v1
5552
with:
56-
node-version: '^10'
53+
node-version: '^12'
5754
- name: Install Dependencies
5855
run: yarn install --frozen-lockfile
5956
- name: Prepare CI Environment
@@ -70,10 +67,7 @@ jobs:
7067
steps:
7168
- name: Checkout Code
7269
uses: actions/checkout@v2
73-
- name: Install Node
74-
uses: actions/setup-node@v1
75-
with:
76-
node-version: '^10'
70+
- uses: volta-cli/action@v1
7771
- name: Raise Watched File Limit
7872
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
7973
- name: Install Dependencies
@@ -100,10 +94,7 @@ jobs:
10094
steps:
10195
- name: Checkout Code
10296
uses: actions/checkout@v2
103-
- name: Install Node
104-
uses: actions/setup-node@v1
105-
with:
106-
node-version: '^10'
97+
- uses: volta-cli/action@v1
10798
- name: Raise Watched File Limit
10899
run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
109100
- name: Install Dependencies

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
"hawk": "7"
123123
},
124124
"engines": {
125-
"node": "10.* || >= 12.*"
125+
"node": ">= 12.*"
126126
},
127127
"ember-addon": {
128128
"configPath": "tests/dummy/config",
@@ -139,7 +139,7 @@
139139
"proseWrap": "never"
140140
},
141141
"volta": {
142-
"node": "10.23.0",
143-
"yarn": "1.22.10"
142+
"node": "12.22.9",
143+
"yarn": "1.22.17"
144144
}
145145
}

0 commit comments

Comments
 (0)