-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken SSR: environment-glimmerx does not support nodejs modules #223
Comments
Can you provide a reproduction for this issue? It would surprise me if in general CJS modules were working for the browser but specifically breaking in SSR, especially since CJS is still so common in the Node ecosystem as a whole. I do see that GlimmerX ships both versions, but I'd love to understand if that's working around some other intrinsic incompatibility between Vite's SSR mode and CJS modules. |
may be related: josemarluedke/glimmer-apollo#45 @dfreeman reproduction: https://github.com/lifeart/glimmerx-workshop/tree/glint-ssr-issue-reproduction steps to get error: |
As of Glint 0.7.4 native import paths are available, and as of version 0.8.0, Glint no longer exposes any runtime imports itself, so this should no longer be a problem! Check out the migration guide for further details. |
@lifeart any plans to update your vite plugin? |
@knownasilya this update should work without plugin update. But let me know if we could improve smf in |
If I use
ssr build fails with:
if I replace import with glimmerx default-one, SSR works
It will be great to have this package shipped in 2 types: esm & cjs
The text was updated successfully, but these errors were encountered: