Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make error messages for release validation rules cleaner #289

Open
vmax opened this issue May 20, 2021 · 1 comment
Open

Make error messages for release validation rules cleaner #289

vmax opened this issue May 20, 2021 · 1 comment
Labels
priority: medium type: bug type: build

Comments

@vmax
Copy link
Contributor

vmax commented May 20, 2021

  1. don't throw an exception for something that's an expected invalid result; just print a message and exit
  2. figure out why running Kotlin binaries prints weird text mentioning fg
@vmax vmax self-assigned this May 20, 2021
@lolski
Copy link
Member

lolski commented May 20, 2021

don't throw an exception for something that's an expected invalid result; just print a message and exit
For consistency, let's also make sure that we do the same for other rules @vmax .

@vmax vmax removed their assignment Jan 20, 2022
lolski pushed a commit to lolski/dependencies that referenced this issue Oct 7, 2022
@vmax
Fix deploy_brew rule to be compatible with Python 2 (typedb#289)
5821596 
## What is the goal of this PR?

Allow running `deploy_brew` with Python 2 being active system-wide

## What are the changes implemented in this PR?

Fix "TypeError: list object is not an iterator" error by making an iterator out of a list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium type: bug type: build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lolski @vmax