Skip to content

Commit e6aba81

Browse files
committed
proper rebase
1 parent 7ce42c4 commit e6aba81

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

mypy_django_plugin/transformers2/related_managers.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,17 @@ def get_related_manager_type(self, relation: ForeignObjectRel) -> MypyType:
5454
new_manager_info = self.new_typeinfo(name, bases)
5555
return Instance(new_manager_info, [])
5656

57-
def __call__(self, ctx: AttributeContext):
57+
def __call__(self, ctx: AttributeContext) -> MypyType:
5858
super().__call__(ctx)
59-
assert isinstance(self.obj_type, Instance)
59+
if not isinstance(self.obj_type, Instance):
60+
# it's probably a UnionType, do nothing for now
61+
return self.default_attr_type
6062

6163
model_fullname = self.obj_type.type.fullname
6264
model_cls = self.django_context.get_model_class_by_fullname(model_fullname)
6365
if model_cls is None:
6466
return self.default_attr_type
67+
6568
for reverse_manager_name, relation in self.django_context.get_model_relations(model_cls):
6669
if reverse_manager_name == self.name:
6770
return self.get_related_manager_type(relation)

test-data/typecheck/test_request.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
from django.db import models
1616
class MyUser(models.Model):
1717
pass
18-
- case: request_object_user_can_be_descriminated
18+
19+
- case: request_object_user_can_be_discriminated
1920
disable_cache: true
2021
main: |
2122
from django.http.request import HttpRequest

0 commit comments

Comments
 (0)