Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages refer to private _QuerySet class #681

Closed
syastrov opened this issue Jul 29, 2021 · 1 comment · Fixed by #2104
Closed

Error messages refer to private _QuerySet class #681

syastrov opened this issue Jul 29, 2021 · 1 comment · Fixed by #2104
Assignees
@intgr
Labels
bug Something isn't working

Comments

@syastrov
Copy link
Contributor

syastrov commented Jul 29, 2021 •
edited
Loading

Bug report

Error messages on master now refer to the private _QuerySet class.
It's not friendly to users, and doesn't hint about how to properly write the annotations.

We should make the "repr" use either the QuerySet alias (if the 2 type parameters are both the same model) or the django_stubs_ext.ValuesQuerySet alias.

See python/mypy#6501 for a possible hacky way to do this in the plugin.
@syastrov syastrov added the bug Something isn't working label Jul 29, 2021
@syastrov syastrov mentioned this issue Nov 11, 2021
Merged
@UnknownPlatypus UnknownPlatypus mentioned this issue Oct 9, 2022
Closed
@intgr intgr mentioned this issue May 29, 2024
Merged
2 tasks
@intgr
Copy link
Collaborator

intgr commented May 29, 2024

This has been solved as a side-effect of

@intgr intgr closed this as completed May 29, 2024
@intgr intgr self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@intgr intgr

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove QuerySet alias hacks via PEP 696 TypeVar defaults intgr/django-stubs
2 participants
@intgr @syastrov