-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix a few typos #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and correcting these typos, but i have to request some changes:
- when changing strings in tests or code, make sure the characters are properly escaped or change the string type
- if possible, maybe split these changes out into multiple commits (like docs typo fixes and code fixes)
could you maybe post the errors and your system information? (because i am also a maintainer of that package)
|
Hi!
|
i think so
just different commits if possible, it makes it cleaner (in my opinion)
weird, if you can reproduce it, could you try again with Note: i dont know if this is the proper way to set environment variables on non UNIX systems forgot to add in my last comment:
MMS is only required for tests, it does not affect linting (though if it was the postinstall failing, you can try to reinstall everything with also, MMS is not strictly required for testing, as long as you have a mongod server already running that can be used for tests (though you need to set the config properly, which can be more work than its worth for a typo fix) |
Hi! Unfortunately (or fortunately) I can't reproduce the |
thats fine then, it was a optional request anyway only things needs then would be to fix the current syntax problems, then making sure the tests pass and any lint fixes if there are any |
Lint and tests pass locally 👍 |
Codecov ReportBase: 97.11% // Head: 97.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 17 17
Lines 902 902
Branches 245 245
=======================================
Hits 876 876
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 1 minor thing left (will self-apply):
- reverting wording for one changelog entry (just wanna keep the same meaning)
Revert changing of wording, but still fixing the typo
This PR fixes a few typos throughout the repository. I didn't test or lint because
mongodb-memory-server
wasn't building for me locally and I needed to get to sleep haha.