-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.9.0 release #1508
Comments
@johnynek Added! |
I don't know if #1505 is fixable at all? |
I'd like to add #1500 too. If someone can give it one more +1. |
would like #1510 in too. |
I think #1480 is ready too. By the way, I would mention we don't seem to be very proactive on reviewing and merging code. :/ |
#1455 looks good too. |
#1452 also |
@johnynek Updated again. Maybe we should make it a matter of policy that if there's no obvious controversy in the PR the second maintainer to 👍 should be responsible for merging immediately? I know that personally if I review something with multiple 👍s that's been open for a while, I tend to assume that there's a reason it's not merged, and I don't merge it (which is of course self-perpetuating 😦). |
yeah, I'm +1 on that. revert is there if we want. The bigger issues are the ones where there is 1 +1, but no other comments. Like no one else has looked and it should be simple in many cases. |
The flip-side obligation for PR openers will need to be that if there's been related conversation on Gitter it must be linked in the PR. Again, I haven't personally been doing a good job of keeping up with Gitter recently, so if I see something with no comments I tend to assume I missed something there. |
Is this still likely to be released soon? I've been planning to do a release of a downstream project, but have held off on the assumption that this was imminent. |
@philwills Same here. I think we just need to get someone to merge #1511 and someone else with publishing rights to pull the trigger. |
We should also be sure to update the README and website with the new version after. |
It's been a little over two months since 0.8.0, and while there haven't been many big changes since then, I think it's probably time for a new release, and at least three other people agree. 😄
There's nothing more in particular that I personally want to see in 0.9 besides #1506 (
flatMap
syntax forEither
on 2.10 / 2.11 that's consistent withEither#flatMap
in 2.12), but if other people have other things they'd like to wait for, we can expand this list:flatMap
forEither
, etc.) and get it reviewed and merged.StateT
stuff).Reducible
instances).Ior
).FunctionK#and
).NonEmptyList#reverse
).catchNonFatal
forFuture
).Foldable.foldMapM
andReducible.reduceMapM
#1452 (Foldable#foldMapM
).I can write up the release notes on Monday (the 2nd), but if someone beats me to it I'd be happy to review instead.The text was updated successfully, but these errors were encountered: