Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.9.0 release #1508

Closed
11 tasks done
travisbrown opened this issue Dec 30, 2016 · 15 comments
Closed
11 tasks done

Prepare for 0.9.0 release #1508

travisbrown opened this issue Dec 30, 2016 · 15 comments

Comments

@travisbrown
Copy link
Contributor

travisbrown commented Dec 30, 2016

It's been a little over two months since 0.8.0, and while there haven't been many big changes since then, I think it's probably time for a new release, and at least three other people agree. 😄

There's nothing more in particular that I personally want to see in 0.9 besides #1506 (flatMap syntax for Either on 2.10 / 2.11 that's consistent with Either#flatMap in 2.12), but if other people have other things they'd like to wait for, we can expand this list:

I can write up the release notes on Monday (the 2nd), but if someone beats me to it I'd be happy to review instead.

@johnynek
Copy link
Contributor

I want #1466 and #1475

@travisbrown
Copy link
Contributor Author

@johnynek Added!

@notxcain
Copy link
Contributor

I don't know if #1505 is fixable at all?

@johnynek
Copy link
Contributor

johnynek commented Jan 2, 2017

I'd like to add #1500 too. If someone can give it one more +1.

@johnynek
Copy link
Contributor

johnynek commented Jan 2, 2017

would like #1510 in too.

@johnynek
Copy link
Contributor

johnynek commented Jan 2, 2017

I think #1480 is ready too.

By the way, I would mention we don't seem to be very proactive on reviewing and merging code. :/

@johnynek
Copy link
Contributor

johnynek commented Jan 2, 2017

#1455 looks good too.

@johnynek
Copy link
Contributor

johnynek commented Jan 2, 2017

#1452 also

@travisbrown
Copy link
Contributor Author

@johnynek Updated again.

Maybe we should make it a matter of policy that if there's no obvious controversy in the PR the second maintainer to 👍 should be responsible for merging immediately? I know that personally if I review something with multiple 👍s that's been open for a while, I tend to assume that there's a reason it's not merged, and I don't merge it (which is of course self-perpetuating 😦).

@johnynek
Copy link
Contributor

johnynek commented Jan 2, 2017

yeah, I'm +1 on that. revert is there if we want.

The bigger issues are the ones where there is 1 +1, but no other comments. Like no one else has looked and it should be simple in many cases.

@travisbrown
Copy link
Contributor Author

The flip-side obligation for PR openers will need to be that if there's been related conversation on Gitter it must be linked in the PR. Again, I haven't personally been doing a good job of keeping up with Gitter recently, so if I see something with no comments I tend to assume I missed something there.

@travisbrown
Copy link
Contributor Author

@notxcain I just took a look at #1505 and don't really have any idea how to help. I think we should spend some more time trying to fix it, but not before 0.9.0. Does that sound reasonable?

@philwills
Copy link
Contributor

philwills commented Jan 13, 2017

Is this still likely to be released soon? I've been planning to do a release of a downstream project, but have held off on the assumption that this was imminent.

@travisbrown
Copy link
Contributor Author

@philwills Same here. I think we just need to get someone to merge #1511 and someone else with publishing rights to pull the trigger.

@adelbertc
Copy link
Contributor

We should also be sure to update the README and website with the new version after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants