Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel instances are in typeclasses which are subclasses #1657

Closed
yilinwei opened this issue May 10, 2017 · 2 comments
Closed

Kernel instances are in typeclasses which are subclasses #1657

yilinwei opened this issue May 10, 2017 · 2 comments

Comments

@yilinwei
Copy link
Contributor

yilinwei commented May 10, 2017 •
edited
Loading

Both Order and PartialOrder need a Contravariant instance.

Will submit a PR for it shortly.

EDIT: #1659 has proper explanation of the issue.
@ceedubs
Copy link
Contributor

ceedubs commented May 10, 2017

@yilinwei I think that those exist here: https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/functor/Contravariant.scala#L42-L58

@yilinwei yilinwei mentioned this issue May 11, 2017
Merged
5 tasks
@yilinwei yilinwei changed the title Order, PartialOrder Kernel instances are in typeclasses which are subclasses May 11, 2017
@peterneyens
Copy link
Collaborator

Fixed in #1659.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ceedubs @peterneyens @yilinwei