Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EqTests#eqv requires an Eq[A] #2051

Closed
durban opened this issue Nov 27, 2017 · 2 comments
Closed

EqTests#eqv requires an Eq[A] #2051

durban opened this issue Nov 27, 2017 · 2 comments
Labels
help wanted low-hanging fruit testing

Comments

@durban
Copy link
Contributor

durban commented Nov 27, 2017

cats.kernel.laws.discipline.EqTests#eqv requires an implicit Eq[A], while it already has one, in the EqLaws[A] instance it has. Thus the implicit Eq[A] parameter is unnecessary and could be removed.
@johnynek
Copy link
Contributor

+1

@stephen-lazaro
Copy link
Contributor

I can look at this this weekend if no one has bandwidth before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted low-hanging fruit testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@johnynek @kailuowang @durban @stephen-lazaro