-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doctests (excellent first-time issue) #2479
Comments
@kailuowang I'll start working on |
I'll be writing them for |
|
@kailuowang So since Kleisli implements quite a few typeclasses, how much doctesting is too much? Should every method be covered? EDIT: I guess you can never have too much test coverage |
@nasadorian hmm, good question. I think I would focus on methods that are not part of type classes. There a couple of them in |
A little late, but I did not forget! PR is linked... added a handful of doctests and comments to Kleisli! @kailuowang |
Hi @kailuowang can i start for |
@kailuowang can I start with |
@vasiliybondarenko go right ahead! |
@kailuowang i checked |
@kailuowang i will start |
@kailuowang i checked |
@kailuowang i checked the |
I'll pick Show |
Doctests are a great way to provide compilable and testable example code for scaladoc. We should cover as many methods with doctests as possible.
Here is an example of PR adding doctests.
Note that to test the doctests run
sbt coreJVM/test
This issue encompasses the effort of adding more doctest coverage to our type classes and data types.
It would be a great first-time contribution.
If you are interested, please comment here on what type classes or data types you'd like to work on.
The text was updated successfully, but these errors were encountered: