Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctests (excellent first-time issue) #2479

Open
kailuowang opened this issue Sep 7, 2018 · 14 comments
Open

Add doctests (excellent first-time issue) #2479

kailuowang opened this issue Sep 7, 2018 · 14 comments
Labels
documentation good first issue Issues that are easier to take on for first time contributors help wanted

Comments

@kailuowang
Copy link
Contributor

Doctests are a great way to provide compilable and testable example code for scaladoc. We should cover as many methods with doctests as possible.
Here is an example of PR adding doctests.
Note that to test the doctests run sbt coreJVM/test
This issue encompasses the effort of adding more doctest coverage to our type classes and data types.
It would be a great first-time contribution.

If you are interested, please comment here on what type classes or data types you'd like to work on.

@YuvalItzchakov
Copy link
Contributor

YuvalItzchakov commented Sep 9, 2018

@kailuowang I'll start working on Functor :)

@DennisVDB
Copy link
Contributor

I'll be writing them for Semigroup, Group, and Monoid.

@nasadorian
Copy link
Contributor

Kleisli seems pretty barren w.r.t doctests, I can start on that one?

@nasadorian
Copy link
Contributor

nasadorian commented Nov 7, 2018

@kailuowang So since Kleisli implements quite a few typeclasses, how much doctesting is too much? Should every method be covered? EDIT: I guess you can never have too much test coverage

@kailuowang
Copy link
Contributor Author

@nasadorian hmm, good question. I think I would focus on methods that are not part of type classes. There a couple of them in KleisliFunctions. Thanks!

@nasadorian
Copy link
Contributor

A little late, but I did not forget! PR is linked... added a handful of doctests and comments to Kleisli! @kailuowang

@hamednourhani
Copy link
Contributor

Hi @kailuowang can i start for Applicatives ?

@kailuowang kailuowang added the good first issue Issues that are easier to take on for first time contributors label Jun 21, 2019
@vasiliybondarenko
Copy link
Contributor

@kailuowang can I start with OptionT?

@LukaJCB
Copy link
Member

LukaJCB commented Jul 16, 2019

@vasiliybondarenko go right ahead!

@hamednourhani
Copy link
Contributor

hamednourhani commented Sep 9, 2019

@kailuowang i checked Applicative. That was done previously. I will work on EitherT.

@hamednourhani
Copy link
Contributor

@kailuowang i will start Validated.

@hamednourhani
Copy link
Contributor

@kailuowang i checked Ior data type. that was interesting and good opportunity to learn. I will start Ior.

@hamednourhani
Copy link
Contributor

hamednourhani commented Sep 16, 2019

@kailuowang i checked the Chain data type as it used widely in cats and i like to add more doctest to it to learn more.

@muskan3006
Copy link

I'll pick Show

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation good first issue Issues that are easier to take on for first time contributors help wanted
Projects
Development

No branches or pull requests

8 participants