Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop machinist for Dotty #2649

Closed
Alistair-Johnson opened this issue Nov 29, 2018 · 3 comments
Closed

Drop machinist for Dotty #2649

Alistair-Johnson opened this issue Nov 29, 2018 · 3 comments

Comments

@Alistair-Johnson
Copy link
Contributor

Ref https://gitter.im/typelevel/general?at=5c0072ae464b6c0fd667cdfc

@ceedubs
Copy link
Contributor

ceedubs commented Dec 10, 2018

I assume that we would still want to keep machinist for Scala versions before Dotty. How could we go about doing this? Is there a way to make Machinist a no-op for Dotty and still work the same for previous versions?

@drdozer
Copy link
Contributor

drdozer commented Mar 28, 2019

I hit this today. The cats syntax macros broke my dotty use of the syntax. I think we can simply replace the macros with inline defs. Unless they are doing something very clever. So what's the magic for building two versions of the macros project, one using machinist, and one with manually plumbed inline defs?

@rossabaker
Copy link
Member

Fixed by #2925.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants