-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mkString_ that just takes separator string #2663
Comments
Hi @matthughes did you end up working on this? |
@calvinbrown085 I have not. I wanted to see if there was interest before doing the PR as it's pretty simple. Really just adding a new method that delegates to the form: def _mkString(separator: String): String =
_mkString("", separator, "") |
@calvinbrown085 I think this would be a good addition. And it's rather simple, the code you wrote and a doctest should do. |
@kailuowang @matthughes Feel free to take this one since you originally opened the issue :) |
Fixed by #2709 |
Cats provides a Show-compatible version of mkString but it requires all three parameters: prefix, separator, suffix. The std library also provides a mkString that just takes a separator string; this is what I use 90% of the time.
Can we add this? I'd be happy to PR.
The text was updated successfully, but these errors were encountered: