Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a combineKEval method #2707

Closed
LukaJCB opened this issue Jan 23, 2019 · 3 comments · Fixed by #3446
Closed

Provide a combineKEval method #2707

LukaJCB opened this issue Jan 23, 2019 · 3 comments · Fixed by #3446
Labels
Binary Breaking enhancement Triage needed

Comments

@LukaJCB
Copy link
Member

LukaJCB commented Jan 23, 2019

For Apply we currently have map2Eval, which individual instances can override to get short-circuiting. Would be cool to have the same for SemigroupK, as I believe quite a few instances could do some short-circuiting in that way.
@kailuowang
Copy link
Contributor

this would be binary breaking right?

@LukaJCB
Copy link
Member Author

LukaJCB commented Jan 23, 2019

Yeah, atleast for 2.11 :(

@LukaJCB
Copy link
Member Author

LukaJCB commented Jan 23, 2019

Though, maybe it's not such a bad thing, it could fit into other plans such as #2620

@LukaJCB LukaJCB mentioned this issue May 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Binary Breaking enhancement Triage needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add combineKEval and add short-circuiting for foldMapK typelevel/cats
2 participants
@kailuowang @LukaJCB