Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Scala 2.13 replace NonEmptyStream with NonEmptyLazyList #2903

Closed
kailuowang opened this issue Jun 20, 2019 · 3 comments
Closed

On Scala 2.13 replace NonEmptyStream with NonEmptyLazyList #2903

kailuowang opened this issue Jun 20, 2019 · 3 comments
Labels
good first issue Issues that are easier to take on for first time contributors help wanted
Milestone
2.0.0-RC1

Comments

@kailuowang
Copy link
Contributor

kailuowang commented Jun 20, 2019 •
edited
Loading

OneAnd's tailRecM implementation is no longer stack safe on LazyList.
It's time to introduce a NonEmptyLazyList that is a new type to LazyList similar to other NonEmptyXXXX (e.g. NonEmptyVector NonEmptyChain) data types.

Then maybe (definitely in a separate PR) consider deprecate the OneAnd data type on 2.13 (need to duplicate the code to both 2.12- folder and 2.13+ folder and mark the one in 2.13 as deprecated, this probably have chain implications (e.g. the type alias NonEmptyStream in cats.data need to be somehow only deprecated on 2.12-)

I completed the 1st step in #2905. If anyone interested in continue on it please feel free to continue on it.

Update: I was wrong NonEmptyVector didn't not use new type impl, changed to NonEmptyChain
@kailuowang kailuowang added this to the 2.0.0-RC1 milestone Jun 20, 2019
@kailuowang kailuowang mentioned this issue Jun 21, 2019
Closed
@kailuowang kailuowang added the good first issue Issues that are easier to take on for first time contributors label Jun 21, 2019
@nathaniel-may
Copy link

I've pulled your changes and I'm going to give it a try. This will be my first attempt at a cats issue 😬.

@kailuowang
Copy link
Contributor Author

Thanks @nathaniel-may, please don't hesitate to ask questions here or on cats-dev gitter chatroom. Also please merge in master, which has resolved some Scala 2.13 issues.

@nathaniel-may nathaniel-may mentioned this issue Jun 27, 2019
Closed
@kailuowang kailuowang mentioned this issue Jul 3, 2019
Closed
@kailuowang
Copy link
Contributor Author

closed by #2941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are easier to take on for first time contributors help wanted
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging a pull request may close this issue.

Unifies NonEmpty datatypes on 2.13 to the Newtype encoding kailuowang/cats
2 participants
@kailuowang @nathaniel-may