Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use imports for instances and syntax in tests #3262

Closed
travisbrown opened this issue Jan 20, 2020 · 2 comments
Closed

Use imports for instances and syntax in tests #3262

travisbrown opened this issue Jan 20, 2020 · 2 comments

Comments

@travisbrown
Copy link
Contributor

Over the weekend I hit a Dotty bug while trying to run the Cats tests on Dotty, and while the workaround is pretty trivial, it highlighted the fact that our tests aren't really exercising normal usage, since the instances and syntax come from traits that are mixed into CatsSuite (rather than imported from the usual objects).

This feels like overengineering. It lets us avoid one import in each of our test files, but at the expense of testing instances in a way that doesn't represent what our users are actually doing.
@rossabaker
Copy link
Member

I think I'm responsible for this in the early days, and I agree with you now.

@travisbrown travisbrown mentioned this issue Jan 26, 2020
Merged
@travisbrown travisbrown mentioned this issue Feb 19, 2020
Merged
@travisbrown
Copy link
Contributor Author

Done in #3304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossabaker @travisbrown