-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-widen/auto-narrow implicits #3434
Comments
Might be good to try this in a few downstream projects and confirm this doesn't break something. |
Add it to something like |
So as a random datapoint… I added these implicits to every scope in https://github.com/precog/quasar. Everything compiled just fine before and after. There was a 12% performance hit (which is actually a bit less than I was expecting) in compile time after everything was warmed up. To be clear, quasar makes very aggressive use of implicit search across a large section of the codebase, as well as some very complicated type inference, so it probably represents a worse case scenario in terms of compiler performance impact of this change. |
It can be quite frustrating sometimes to insert
widen
ornarrow
calls sometimes just to make the compiler happy, so we thought it could be a good idea to have two little implicits you could import:The text was updated successfully, but these errors were encountered: