Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Contravariant instances #579

Closed
ceedubs opened this issue Oct 18, 2015 · 2 comments
Closed

Missing Contravariant instances #579

ceedubs opened this issue Oct 18, 2015 · 2 comments
Labels
low-hanging fruit

Comments

@ceedubs
Copy link
Contributor

ceedubs commented Oct 18, 2015

There are a number of types that we are either missing Contravariant instances or are not being tested by the ContravariantTests introduced in #578.

I think the following fit into this category: Kleisli, Const, Show, Equal, Order, StateT. There could very possibly be more.

We should add these instances and tests.

https://github.com/non/cats/pull/578/files#diff-5a256f6c87581d09dae79f590a0a91e4R23 should serve as a good example of testing a type's Contravariant instance.
@vikraman vikraman mentioned this issue Oct 28, 2015
Closed
@philwills
Copy link
Contributor

Partially addressed by #626

@DavidGregory084 DavidGregory084 mentioned this issue Mar 11, 2016
Merged
@peterneyens peterneyens mentioned this issue Jul 17, 2016
Merged
@peterneyens
Copy link
Collaborator

I think #1211 added the last missing Contravariant instance, so I am closing this issue.
We can still reopen this if someone finds a missing instance.

@stew stew removed the ready label Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add some Contravariant instances vikraman/cats
4 participants
@stew @philwills @ceedubs @peterneyens