Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all usage of the list Monoid in the docs with the chain Monoid #2429

Closed
LukaJCB opened this issue Aug 20, 2018 · 2 comments · Fixed by #2460
Closed

Replace all usage of the list Monoid in the docs with the chain Monoid #2429

LukaJCB opened this issue Aug 20, 2018 · 2 comments · Fixed by #2460
Labels
documentation help wanted low-hanging fruit

Comments

@LukaJCB
Copy link
Member

LukaJCB commented Aug 20, 2018

Using Chains Monoid instead of Lists can give us an enormous performance boost. We should encourage our users to use it instead of list in many cases, such as, Validated, Ior, Writer or Const.
@jan0sch
Copy link
Contributor

jan0sch commented Sep 3, 2018

Do you have a small example? Then I'll try to do this.

@LukaJCB
Copy link
Member Author

LukaJCB commented Sep 3, 2018

For example, you could start by using NonEmptyChain instead of NonEmptyList for the Ior docs :) https://typelevel.org/cats/datatypes/ior.html

jan0sch added a commit to wegtam/cats that referenced this issue Sep 3, 2018
@jan0sch
typelevel#2429 Replace list Monoid in the docs with the chain Monoid
6306b3b 
* Ior
jan0sch added a commit to wegtam/cats that referenced this issue Sep 3, 2018
@jan0sch
typelevel#2429 Replace list Monoid in the docs with the chain Monoid
2ed5175 
* IorT
@jan0sch jan0sch mentioned this issue Sep 3, 2018
Merged
LukaJCB pushed a commit that referenced this issue Sep 4, 2018
@jan0sch
#2429 Replace all usage of the list Monoid in the docs with the chain…
bc43702 
… Monoid (#2460)

* #2429 Replace list Monoid in the docs with the chain Monoid

* Ior

* #2429 Replace list Monoid in the docs with the chain Monoid

* IorT
@rtitle rtitle mentioned this issue Feb 13, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help wanted low-hanging fruit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2429 Replace all usage of the list Monoid in the docs with the chain Monoid wegtam/cats
2 participants
@jan0sch @LukaJCB