You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bpholt had an excellent minimization in #52 (comment) demonstrating why we needed INothing instead of Nothing. Unfortunately, subsequent refactors made it no longer applicable and I was unable to find another one, tracked in #73.
I took a quick try at replacing INothing with Nothing. So far I encountered two issues:
To get the Encoder[INothing] into implicit scope on Scala 3, we put it inside a companion object for INothing. We can't do this with Nothing.
type mismatch;
found : cats.data.Kleisli[cats.effect.IO,natchez.Span[cats.effect.IO],Option[Nothing]]
required: cats.data.Kleisli[[+A]cats.effect.IO[A],natchez.Span[[+A]cats.effect.IO[A]],Option[Result]]
Note: Option[Nothing] <: Option[Result], but class Kleisli is invariant in type B.
You may wish to define B as +B instead.
Update: the broken compile test is only broken on Scala 2, Scala 3 seems okay.
The text was updated successfully, but these errors were encountered:
I took another try at the Circe PR this afternoon. It works in Scala 3 but some form of INothing is needed for Scala 2.13. I guess we're stuck with it for now.
To follow suit with typelevel/fs2#2870.
@bpholt had an excellent minimization in #52 (comment) demonstrating why we needed
INothing
instead ofNothing
. Unfortunately, subsequent refactors made it no longer applicable and I was unable to find another one, tracked in #73.I took a quick try at replacing
INothing
withNothing
. So far I encountered two issues:To get the
Encoder[INothing]
into implicit scope on Scala 3, we put it inside a companion object forINothing
. We can't do this withNothing
.feral/lambda/shared/src/main/scala-3/feral/lambda/INothing.scala
Lines 27 to 28 in 81d1997
This compile test no longer compiles, which may mean trouble for inference when using
Kleisli
-based tracing.feral/lambda/shared/src/test/scala/feral/lambda/TracedHandlerSuite.scala
Line 39 in 81d1997
Update: the broken compile test is only broken on Scala 2, Scala 3 seems okay.
The text was updated successfully, but these errors were encountered: