Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fs2CodeGenerator available in artifact #67

Closed
OlafurD opened this issue Apr 17, 2019 · 3 comments
Closed

Make Fs2CodeGenerator available in artifact #67

OlafurD opened this issue Apr 17, 2019 · 3 comments

Comments

@OlafurD
Copy link

OlafurD commented Apr 17, 2019

I'm using ScalaPB in an environment with no SBT (we're using Pants) using ScalaPBC instead of the SBT plugin to generate the proto implementation.

ScalaPBC has the option of specifying a custom code generator (instead of the default ScalaPbCodeGenerator). Would it be possible to publish the FS2CodeGenerator in an maven artifact? The org.lyranthe.fs2-grpc.java-runtime package does not seem to have this artifact

@rossabaker
Copy link
Member

Sorry for the delayed reply. I just saw this. It's published in org.lyranthe.fs2_grpc.java_runtime.sbt_gen in the sbt-java-gen. I will look into moving it into java-runtime.

@rossabaker
Copy link
Member

There is currently no dependency between java-runtime and sbt-java-gen, and I don't know that we'd want all the dependencies of the latter in sbt scope. Maybe a third artifact is the way forward here.

@ahjohannessen
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants