Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style inconsistencies #889

Closed
morgen-peschke opened this issue Feb 13, 2025 · 0 comments · Fixed by #890
Closed

Fix style inconsistencies #889

morgen-peschke opened this issue Feb 13, 2025 · 0 comments · Fixed by #890

Comments

@morgen-peschke
Copy link
Contributor

morgen-peschke commented Feb 13, 2025 •
edited
Loading

I was a little surprised that the imports can be mixed between * and _ styles. Might be good to follow up to switch entirely to * for consistency, but absolutely not blocking this PR.

Originally posted by @samspills in #850 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some warnings related to -xsource:3 morgen-peschke/log4cats
1 participant
@morgen-peschke