-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarter caching in CI #268
Comments
One idea to fix might be to determine the cache key not just from the build configuration, but also from the matrix. Effectively each job in the matrix would get its own cache. GH actions supports caches of up to 10 GB before it starts evicting old caches. If each job gets its own cache this could add up real quick, at which point it would be useless. |
Perhaps this could be mitigated by using restore keys, provided the keys were prefixed in a way that allowed the cache to be layered nicely |
That's a good point. I'd say if we can get sbt and plugins out of the cache then it's a win. Library deps are icing on the cake :) |
Seems we may be caching some files we are not supposed to, like |
The setup-java action now supports caching. I think we should just use that and call it a day. |
See also some discussion about why the "smarter caching" proposal that was originally the goal of this issue, actually would not work. tl;dr if you use the restore key to fallback to a non-exact-match cache, then when you create a new cache it will also include unnecessary stuff from the fallback cache. This causes your cache to grow unboundedly. |
TwoThree things to consider:build.sbt
etc.The text was updated successfully, but these errors were encountered: