Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecs for Native and JS types #1119

Open
aponos opened this issue Aug 24, 2024 · 2 comments
Open

Codecs for Native and JS types #1119

aponos opened this issue Aug 24, 2024 · 2 comments

Comments

@aponos
Copy link

aponos commented Aug 24, 2024

Hi 👋!

I would like to contribute, adding some codecs for the Native and JS platforms. For example, the bytea type can also be converted to JS UInt8Array.

I just have one question regarding the code style of skunk. Those codecs should be included in the core project? Or it is better to have them in their own project, like the circe and refined codecs?

@mpilquist
Copy link
Member

Yeah, core project makes sense to me. Feel free to open a draft PR to get some feedback before doing a whole bunch of codecs.

@aponos
Copy link
Author

aponos commented Aug 25, 2024

Thank you for your response @mpilquist!

I have opened the draft PR, exposing the idea of the UInt8Array to bytea codec, as a showcase to add more codecs if everything is ok. What do you think about the package scalajs.codec and the codec name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants