Add go-to-definition support on 'instanceof' keyword

Author: rbuckton

src/compiler/checker.ts

@@ -45992,6 +45992,21 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             case SyntaxKind.ImportKeyword:
             case SyntaxKind.NewKeyword:
                 return isMetaProperty(node.parent) ? checkMetaPropertyKeyword(node.parent).symbol : undefined;
+            case SyntaxKind.InstanceOfKeyword:
+                if (isBinaryExpression(node.parent)) {
+                    const type = getTypeOfExpression(node.parent.right);
+                    const hasInstanceMethodType = getSymbolHasInstanceMethodOfObjectType(type);
+                    // const hasInstancePropertyName = getPropertyNameForKnownSymbolName("hasInstance");
+                    // const hasInstanceProperty = getPropertyOfObjectType(type, hasInstancePropertyName);
+                    // if (hasInstanceProperty) {
+                    //     const hasInstancePropertyType = getTypeOfSymbol(hasInstanceProperty);
+                    //     if (hasInstancePropertyType && getSignaturesOfType(hasInstancePropertyType, SignatureKind.Call).length !== 0) {
+                    //         return hasInstanceProperty;
+                    //     }
+                    // }
+                    return hasInstanceMethodType?.symbol ?? type.symbol;
+                }
+                return undefined;
             case SyntaxKind.MetaProperty:
                 return checkExpression(node as Expression).symbol;
             case SyntaxKind.JsxNamespacedName:

src/services/goToDefinition.ts

@@ -101,7 +101,7 @@ import {
     TypeChecker,
     TypeFlags,
     TypeReference,
-    unescapeLeadingUnderscores,
+    unescapeLeadingUnderscores
 } from "./_namespaces/ts";
 
 /** @internal */

tests/baselines/reference/goToDefinitionInstanceof1.baseline.jsonc

@@ -0,0 +1,19 @@
+// === goToDefinition ===
+// === /tests/cases/fourslash/goToDefinitionInstanceof1.ts ===
+// <|class  [|C|] {
+// }|>
+// declare var obj: any;
+// obj /*GOTO DEF*/instanceof C;
+
+  // === Details ===
+  [
+   {
+    "kind": "class",
+    "name": "C",
+    "containerName": "",
+    "isLocal": false,
+    "isAmbient": false,
+    "unverified": false,
+    "failedAliasResolution": false
+   }
+  ]

tests/baselines/reference/goToDefinitionInstanceof2.baseline.jsonc

@@ -0,0 +1,20 @@
+// === goToDefinition ===
+// === /main.ts ===
+// class C {
+//   <|static [|[Symbol.hasInstance]|](value: unknown): boolean { return true; }|>
+// }
+// declare var obj: any;
+// obj /*GOTO DEF*/instanceof C;
+
+  // === Details ===
+  [
+   {
+    "kind": "method",
+    "name": "[Symbol.hasInstance]",
+    "containerName": "C",
+    "isLocal": false,
+    "isAmbient": false,
+    "unverified": false,
+    "failedAliasResolution": false
+   }
+  ]

tests/cases/fourslash/goToDefinitionInstanceof1.ts

@@ -0,0 +1,8 @@
+/// <reference path="fourslash.ts" />
+
+//// class /*end*/ C {
+//// }
+//// declare var obj: any;
+//// obj [|/*start*/instanceof|] C;
+
+verify.baselineGoToDefinition("start");

tests/cases/fourslash/goToDefinitionInstanceof2.ts

@@ -0,0 +1,11 @@
+/// <reference path="fourslash.ts" />
+
+// @lib: esnext
+// @filename: /main.ts
+//// class C {
+////   static /*end*/[Symbol.hasInstance](value: unknown): boolean { return true; }
+//// }
+//// declare var obj: any;
+//// obj [|/*start*/instanceof|] C;
+
+verify.baselineGoToDefinition("start");