Skip to content

Commit bac841e

Browse files
authored
Fix missing abstract keyword in completion (microsoft#45710)
* first commit * tests
1 parent 7032f6b commit bac841e

6 files changed

+87
-0
lines changed

Diff for: src/harness/fourslashInterfaceImpl.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1292,6 +1292,7 @@ namespace FourSlashInterface {
12921292
"let",
12931293
"package",
12941294
"yield",
1295+
"abstract",
12951296
"as",
12961297
"asserts",
12971298
"any",
@@ -1495,6 +1496,7 @@ namespace FourSlashInterface {
14951496
"let",
14961497
"package",
14971498
"yield",
1499+
"abstract",
14981500
"as",
14991501
"asserts",
15001502
"any",

Diff for: src/services/completions.ts

+1
Original file line numberDiff line numberDiff line change
@@ -2960,6 +2960,7 @@ namespace ts.Completions {
29602960
|| kind === SyntaxKind.ModuleKeyword
29612961
|| kind === SyntaxKind.TypeKeyword
29622962
|| kind === SyntaxKind.NamespaceKeyword
2963+
|| kind === SyntaxKind.AbstractKeyword
29632964
|| isTypeKeyword(kind) && kind !== SyntaxKind.UndefinedKeyword;
29642965
case KeywordCompletionFilters.FunctionLikeBodyKeywords:
29652966
return isFunctionLikeBodyKeyword(kind);

Diff for: tests/baselines/reference/completionsCommentsClass.baseline

+12
Original file line numberDiff line numberDiff line change
@@ -3672,6 +3672,18 @@
36723672
}
36733673
]
36743674
},
3675+
{
3676+
"name": "abstract",
3677+
"kind": "keyword",
3678+
"kindModifiers": "",
3679+
"sortText": "15",
3680+
"displayParts": [
3681+
{
3682+
"text": "abstract",
3683+
"kind": "keyword"
3684+
}
3685+
]
3686+
},
36753687
{
36763688
"name": "as",
36773689
"kind": "keyword",

Diff for: tests/baselines/reference/completionsCommentsClassMembers.baseline

+24
Original file line numberDiff line numberDiff line change
@@ -86508,6 +86508,18 @@
8650886508
}
8650986509
]
8651086510
},
86511+
{
86512+
"name": "abstract",
86513+
"kind": "keyword",
86514+
"kindModifiers": "",
86515+
"sortText": "15",
86516+
"displayParts": [
86517+
{
86518+
"text": "abstract",
86519+
"kind": "keyword"
86520+
}
86521+
]
86522+
},
8651186523
{
8651286524
"name": "as",
8651386525
"kind": "keyword",
@@ -91852,6 +91864,18 @@
9185291864
}
9185391865
]
9185491866
},
91867+
{
91868+
"name": "abstract",
91869+
"kind": "keyword",
91870+
"kindModifiers": "",
91871+
"sortText": "15",
91872+
"displayParts": [
91873+
{
91874+
"text": "abstract",
91875+
"kind": "keyword"
91876+
}
91877+
]
91878+
},
9185591879
{
9185691880
"name": "as",
9185791881
"kind": "keyword",

Diff for: tests/baselines/reference/completionsCommentsCommentParsing.baseline

+24
Original file line numberDiff line numberDiff line change
@@ -23145,6 +23145,18 @@
2314523145
}
2314623146
]
2314723147
},
23148+
{
23149+
"name": "abstract",
23150+
"kind": "keyword",
23151+
"kindModifiers": "",
23152+
"sortText": "15",
23153+
"displayParts": [
23154+
{
23155+
"text": "abstract",
23156+
"kind": "keyword"
23157+
}
23158+
]
23159+
},
2314823160
{
2314923161
"name": "as",
2315023162
"kind": "keyword",
@@ -41018,6 +41030,18 @@
4101841030
}
4101941031
]
4102041032
},
41033+
{
41034+
"name": "abstract",
41035+
"kind": "keyword",
41036+
"kindModifiers": "",
41037+
"sortText": "15",
41038+
"displayParts": [
41039+
{
41040+
"text": "abstract",
41041+
"kind": "keyword"
41042+
}
41043+
]
41044+
},
4102141045
{
4102241046
"name": "as",
4102341047
"kind": "keyword",

Diff for: tests/baselines/reference/completionsCommentsFunctionExpression.baseline

+24
Original file line numberDiff line numberDiff line change
@@ -3579,6 +3579,18 @@
35793579
}
35803580
]
35813581
},
3582+
{
3583+
"name": "abstract",
3584+
"kind": "keyword",
3585+
"kindModifiers": "",
3586+
"sortText": "15",
3587+
"displayParts": [
3588+
{
3589+
"text": "abstract",
3590+
"kind": "keyword"
3591+
}
3592+
]
3593+
},
35823594
{
35833595
"name": "as",
35843596
"kind": "keyword",
@@ -8289,6 +8301,18 @@
82898301
}
82908302
]
82918303
},
8304+
{
8305+
"name": "abstract",
8306+
"kind": "keyword",
8307+
"kindModifiers": "",
8308+
"sortText": "15",
8309+
"displayParts": [
8310+
{
8311+
"text": "abstract",
8312+
"kind": "keyword"
8313+
}
8314+
]
8315+
},
82928316
{
82938317
"name": "as",
82948318
"kind": "keyword",

0 commit comments

Comments
 (0)