Add NodeWithParent type

Author: dbarabashh

packages/eslint-plugin/src/rules/no-confusing-void-expression.ts

@@ -1,4 +1,8 @@
-import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
+import type {
+  NodeWithParent,
+  TSESLint,
+  TSESTree,
+} from '@typescript-eslint/utils';
 
 import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 import * as tsutils from 'ts-api-utils';
@@ -300,8 +304,8 @@ export default createRule<Options, MessageId>({
      * @param node The void expression node to check.
      * @returns Invalid ancestor node if it was found. `null` otherwise.
      */
-    function findInvalidAncestor(node: TSESTree.Node): InvalidAncestor | null {
-      const parent = nullThrows(node.parent, NullThrowsReasons.MissingParent);
+    function findInvalidAncestor(node: NodeWithParent): InvalidAncestor | null {
+      const parent = node.parent;
       if (
         parent.type === AST_NODE_TYPES.SequenceExpression &&
         node !== parent.expressions[parent.expressions.length - 1]
@@ -365,17 +369,14 @@ export default createRule<Options, MessageId>({
     /** Checks whether the return statement is the last statement in a function body. */
     function isFinalReturn(node: TSESTree.ReturnStatement): boolean {
       // the parent must be a block
-      const block = nullThrows(node.parent, NullThrowsReasons.MissingParent);
+      const block = node.parent;
       if (block.type !== AST_NODE_TYPES.BlockStatement) {
         // e.g. `if (cond) return;` (not in a block)
         return false;
       }
 
       // the block's parent must be a function
-      const blockParent = nullThrows(
-        block.parent,
-        NullThrowsReasons.MissingParent,
-      );
+      const blockParent = block.parent;
       if (
         ![
           AST_NODE_TYPES.ArrowFunctionExpression,

packages/scope-manager/src/definition/DefinitionBase.ts

@@ -1,15 +1,10 @@
-import type { TSESTree } from '@typescript-eslint/types';
+import type { NodeWithParent, TSESTree } from '@typescript-eslint/types';
 
 import type { DefinitionType } from './DefinitionType';
 
 import { createIdGenerator } from '../ID';
 
 const generator = createIdGenerator();
-/**
- * Helper type to exclude Program from valid definition nodes
- * Program is the root node and doesn't have a parent property
- */
-export type NodeWithParent = Exclude<TSESTree.Node, TSESTree.Program>;
 
 export abstract class DefinitionBase<
   Type extends DefinitionType,

packages/scope-manager/src/definition/ImplicitGlobalVariableDefinition.ts

@@ -1,6 +1,4 @@
-import type { TSESTree } from '@typescript-eslint/types';
-
-import type { NodeWithParent } from './DefinitionBase';
+import type { NodeWithParent, TSESTree } from '@typescript-eslint/types';
 
 import { DefinitionBase } from './DefinitionBase';
 import { DefinitionType } from './DefinitionType';

packages/scope-manager/src/referencer/Reference.ts

@@ -1,6 +1,5 @@
-import type { TSESTree } from '@typescript-eslint/types';
+import type { NodeWithParent, TSESTree } from '@typescript-eslint/types';
 
-import type { NodeWithParent } from '../definition/DefinitionBase';
 import type { Scope } from '../scope';
 import type { Variable } from '../variable';
 

packages/types/src/ts-estree.ts

@@ -254,3 +254,4 @@ declare module './generated/ast-spec' {
 }
 
 export * as TSESTree from './generated/ast-spec';
+export type NodeWithParent = Exclude<TSESTree.Node, TSESTree.Program>;

packages/utils/src/ts-estree.ts

@@ -1,11 +1,11 @@
 // for convenience's sake - export the types directly from here so consumers
 // don't need to reference/install both packages in their code
-
 export {
   AST_NODE_TYPES,
   AST_TOKEN_TYPES,
   TSESTree,
 } from '@typescript-eslint/types';
+export type { NodeWithParent } from '@typescript-eslint/types';
 
 export type {
   ParserServices,