Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] fix autofixer for computed properties #1662

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1658

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1662 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
+ Coverage   95.35%   95.37%   +0.02%     
==========================================
  Files         145      146       +1     
  Lines        6804     6836      +32     
  Branches     1958     1965       +7     
==========================================
+ Hits         6488     6520      +32     
  Misses        111      111              
  Partials      205      205
Impacted Files Coverage Δ
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100% <100%> (ø)
packages/eslint-plugin/src/util/types.ts 81.3% <100%> (+0.35%) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 73.68% <100%> (+1.46%) ⬆️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-condition] Optional chaining autofix with index access
2 participants