Enable caching

smillst · web-flow · commit fc3a55d3521b · 2025-10-01T09:02:14.000-07:00
diff --git a/checker/src/main/java/org/checkerframework/checker/initialization/InitializationAnnotatedTypeFactory.java b/checker/src/main/java/org/checkerframework/checker/initialization/InitializationAnnotatedTypeFactory.java
@@ -800,10 +800,8 @@ public Void visitNewClass(NewClassTree tree, AnnotatedTypeMirror p) {
         if (!TreeUtils.isStandaloneExpression(a)) {
           continue;
         }
-        boolean oldShouldCache = shouldCache;
-        shouldCache = false;
+
         AnnotatedTypeMirror t = getAnnotatedType(a);
-        shouldCache = oldShouldCache;
         allInitialized &= (isInitialized(t) || isFbcBottom(t));
       }
       if (!allInitialized) {
diff --git a/checker/tests/nullness/Issue6623.java b/checker/tests/nullness/Issue6623.java
@@ -4,13 +4,11 @@
 public class Issue6623 {
 
   public List<TargetOuter> getUserData(List<SrcOuter> input) {
-    // Fixing issue #6623 will eliminate this warning.
     return input.stream()
         .map(
             c ->
                 new TargetOuter(
                     c.data().stream()
-                        // :: warning: (slow.typechecking)
                         .map(
                             inner ->
                                 new TargetInner(

Original file line number	Diff line number	Diff line change
`@@ -800,10 +800,8 @@ public Void visitNewClass(NewClassTree tree, AnnotatedTypeMirror p) {`
`800`	`800`	`if (!TreeUtils.isStandaloneExpression(a)) {`
`801`	`801`	`continue;`
`802`	`802`	`}`
`803`		`- boolean oldShouldCache = shouldCache;`
`804`		`- shouldCache = false;`
	`803`	`+`
`805`	`804`	`AnnotatedTypeMirror t = getAnnotatedType(a);`
`806`		`- shouldCache = oldShouldCache;`
`807`	`805`	`allInitialized &= (isInitialized(t) \|\| isFbcBottom(t));`
`808`	`806`	`}`
`809`	`807`	`if (!allInitialized) {`