Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Ainfer causes crash for basic assignment #3428

Closed
jwaataja opened this issue Jul 4, 2020 · 0 comments · Fixed by #3436
Closed

-Ainfer causes crash for basic assignment #3428

jwaataja opened this issue Jul 4, 2020 · 0 comments · Fixed by #3436
Assignees
@kelloggm

Comments

@jwaataja
Copy link
Contributor

jwaataja commented Jul 4, 2020

When using -Ainfer with a basic assignment, I get a crash. Here's the code

import org.checkerframework.checker.nullness.qual.*;

public class C {
    public void f(Object param) {
        param = null;
    }
}
$CHECKERFRAMEWORK/checker/bin/javac C.java -processor Nullnesschecker -Ainfer=stubs

error: Tried printing an unprintable class to a stub file during WPI: C
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: C.java
  Exception: java.lang.Throwable; java.lang.Throwable
  	at org.checkerframework.javacutil.BugInCF.<init>(BugInCF.java:14)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.isPrintable(SceneToStubWriter.java:646)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.writeImpl(SceneToStubWriter.java:597)
  	at org.checkerframework.common.wholeprograminference.SceneToStubWriter.write(SceneToStubWriter.java:89)
  	at org.checkerframework.common.wholeprograminference.scenelib.ASceneWrapper.writeToFile(ASceneWrapper.java:146)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenesStorage.writeScenes(WholeProgramInferenceScenesStorage.java:110)
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenes.writeResultsToFile(WholeProgramInferenceScenes.java:423)
  	at org.checkerframework.framework.type.AnnotatedTypeFactory.postProcessClassTree(AnnotatedTypeFactory.java:1121)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:327)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:165)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
  	at org.checkerframework.framework.source.SourceVisitor.visit(SourceVisitor.java:82)
  	at org.checkerframework.framework.source.SourceChecker.typeProcess(SourceChecker.java:894)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:510)
  	at org.checkerframework.javacutil.AbstractTypeProcessor$AttributionTaskListener.finished(AbstractTypeProcessor.java:190)
  	at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedTaskListener.finished(ClientCodeWrapper.java:828)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1375)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
  	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
  	at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:43)
C.java:5: error: [assignment.type.incompatible] incompatible types in assignment.
        param = null;
                ^
  found   : null
  required: @Initialized @NonNull Object
2 errors

This does not occur with -Ainfer=jaifs.
Like with #3422 I get a different crash with checker/bin-devel/javac,

$CHECKERFRAMEWORK/checker/bin-devel/javac C.java -processor Nullnesschecker -Ainfer=stubs

error: SourceChecker.typeProcess: unexpected Throwable (NoSuchMethodError) while processing C.java; message: 'java.lang.String scenelib.annotations.util.JVMNames.getJVMMethodSignature(javax.lang.model.element.ExecutableElement)'
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: C.java
  Last visited tree at line 3 column 1:
  public class C {
  Exception: java.lang.NoSuchMethodError: 'java.lang.String scenelib.annotations.util.JVMNames.getJVMMethodSignature(javax.lang.model.element.ExecutableElement)'; java.lang.NoSuchMethodError: 'java.lang.String scenelib.annotations.util.JVMNames.getJVMMethodSignature(javax.lang.model.element.ExecutableElement)'
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenes.updateFromLocalAssignment(WholeProgramInferenceScenes.java:234)
  	at org.checkerframework.framework.flow.CFAbstractTransfer.visitAssignment(CFAbstractTransfer.java:823)
  	at org.checkerframework.framework.flow.CFAbstractTransfer.visitAssignment(CFAbstractTransfer.java:91)
  	at org.checkerframework.dataflow.cfg.node.AssignmentNode.accept(AssignmentNode.java:62)
  	at org.checkerframework.dataflow.analysis.AbstractAnalysis.callTransferFunction(AbstractAnalysis.java:332)
  	at org.checkerframework.dataflow.analysis.ForwardAnalysisImpl.callTransferFunction(ForwardAnalysisImpl.java:373)
  	at org.checkerframework.dataflow.analysis.ForwardAnalysisImpl.performAnalysisBlock(ForwardAnalysisImpl.java:128)
  	at org.checkerframework.dataflow.analysis.ForwardAnalysisImpl.performAnalysis(ForwardAnalysisImpl.java:105)
  	at org.checkerframework.framework.flow.CFAbstractAnalysis.performAnalysis(CFAbstractAnalysis.java:109)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.analyze(GenericAnnotatedTypeFactory.java:1249)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.performFlowAnalysis(GenericAnnotatedTypeFactory.java:1161)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.checkAndPerformFlowAnalysis(GenericAnnotatedTypeFactory.java:1551)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.preProcessClassTree(GenericAnnotatedTypeFactory.java:258)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:307)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:165)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
  	at org.checkerframework.framework.source.SourceVisitor.visit(SourceVisitor.java:82)
  	at org.checkerframework.framework.source.SourceChecker.typeProcess(SourceChecker.java:894)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:510)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:503)
  	at org.checkerframework.javacutil.AbstractTypeProcessor$AttributionTaskListener.finished(AbstractTypeProcessor.java:190)
  	at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedTaskListener.finished(ClientCodeWrapper.java:828)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1375)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
  	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
  	at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:43)
error: SourceChecker.typeProcess: unexpected Throwable (NoSuchMethodError) while processing C.java; message: 'java.lang.String scenelib.annotations.util.JVMNames.getJVMMethodSignature(javax.lang.model.element.ExecutableElement)'
  ; The Checker Framework crashed.  Please report the crash.
  Compilation unit: C.java
  Last visited tree at line 3 column 1:
  public class C {
  Exception: java.lang.NoSuchMethodError: 'java.lang.String scenelib.annotations.util.JVMNames.getJVMMethodSignature(javax.lang.model.element.ExecutableElement)'; java.lang.NoSuchMethodError: 'java.lang.String scenelib.annotations.util.JVMNames.getJVMMethodSignature(javax.lang.model.element.ExecutableElement)'
  	at org.checkerframework.common.wholeprograminference.WholeProgramInferenceScenes.updateFromLocalAssignment(WholeProgramInferenceScenes.java:234)
  	at org.checkerframework.framework.flow.CFAbstractTransfer.visitAssignment(CFAbstractTransfer.java:823)
  	at org.checkerframework.checker.initialization.InitializationTransfer.visitAssignment(InitializationTransfer.java:149)
  	at org.checkerframework.checker.initialization.InitializationTransfer.visitAssignment(InitializationTransfer.java:57)
  	at org.checkerframework.dataflow.cfg.node.AssignmentNode.accept(AssignmentNode.java:62)
  	at org.checkerframework.dataflow.analysis.AbstractAnalysis.callTransferFunction(AbstractAnalysis.java:332)
  	at org.checkerframework.dataflow.analysis.ForwardAnalysisImpl.callTransferFunction(ForwardAnalysisImpl.java:373)
  	at org.checkerframework.dataflow.analysis.ForwardAnalysisImpl.performAnalysisBlock(ForwardAnalysisImpl.java:128)
  	at org.checkerframework.dataflow.analysis.ForwardAnalysisImpl.performAnalysis(ForwardAnalysisImpl.java:105)
  	at org.checkerframework.framework.flow.CFAbstractAnalysis.performAnalysis(CFAbstractAnalysis.java:109)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.analyze(GenericAnnotatedTypeFactory.java:1249)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.performFlowAnalysis(GenericAnnotatedTypeFactory.java:1161)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.checkAndPerformFlowAnalysis(GenericAnnotatedTypeFactory.java:1551)
  	at org.checkerframework.framework.type.GenericAnnotatedTypeFactory.preProcessClassTree(GenericAnnotatedTypeFactory.java:258)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:307)
  	at org.checkerframework.common.basetype.BaseTypeVisitor.visitClass(BaseTypeVisitor.java:165)
  	at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCClassDecl.accept(JCTree.java:808)
  	at jdk.compiler/com.sun.source.util.TreePathScanner.scan(TreePathScanner.java:56)
  	at org.checkerframework.framework.source.SourceVisitor.visit(SourceVisitor.java:82)
  	at org.checkerframework.framework.source.SourceChecker.typeProcess(SourceChecker.java:894)
  	at org.checkerframework.common.basetype.BaseTypeChecker.typeProcess(BaseTypeChecker.java:510)
  	at org.checkerframework.javacutil.AbstractTypeProcessor$AttributionTaskListener.finished(AbstractTypeProcessor.java:190)
  	at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedTaskListener.finished(ClientCodeWrapper.java:828)
  	at jdk.compiler/com.sun.tools.javac.api.MultiTaskListener.finished(MultiTaskListener.java:132)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1418)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.flow(JavaCompiler.java:1375)
  	at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:311)
  	at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:170)
  	at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:57)
  	at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:43)
2 errors

This crash happens with both -Ainfer=stubs and -Ainfer=jaifs.

Here's the full output for

$CHECKERFRAMEWORK/checker/bin/javac C.java -processor Nullnesschecker -Ainfer=stubs -version -verbose -AprintAllQualifiers

and

$CHECKERFRAMEWORK/checker/bin-devel/javac C.java -processor Nullnesschecker -Ainfer=stubs -version -verbose -AprintAllQualifiers

bin-javac-output.txt
bin-devel-javac-output.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelloggm kelloggm

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kelloggm @jwaataja