-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in AbstractAtmComboVisitor visitArray_Typevar .. defaultAction #3612
Comments
Just for the reference, the error goes away after relevant annotations are added - private static final Function1<ResultSet, Function0<Object>> AUTO_ROW_BUILDER_FACTORY =
+ private static final Function1<ResultSet, Function0<@Nullable Object>> AUTO_ROW_BUILDER_FACTORY =
resultSet -> {
final ResultSetMetaData metaData;
@@ -93,7 +96,7 @@
} else {
//noinspection unchecked
- return (Function0) () -> {
+ return (Function0<@Nullable Object>) () -> {
try {
- final List<Object> list = new ArrayList<>();
+ final List<@Nullable Object> list = new ArrayList<>();
for (int i = 0; i < columnCount; i++) {
if (metaData.getColumnType(i + 1) == Types.TIMESTAMP) { |
This also causes issues with ASM (used by forbiddenapis), see policeman-tools/forbidden-apis#173 Javac creates a bad class file when you use type annotations inside a try...catch, that causes many third party tools to fail. |
The code is with the body of a lambda, so it might be related to #979. |
I can't reproduce this crash. It was like fixed when #979 was merged. |
checkerframework 3.6.0
org.checkerframework gradle plugin 0.5.9
CI failure: https://github.com/apache/calcite/runs/1051080062?check_suite_focus=true#step:4:15495
The sequence to reproduce could be as follows:
Code in question
https://github.com/apache/calcite/blob/39e3acd6ae8cd271d4d0b19c07be473dcff3bd6c/core/src/main/java/org/apache/calcite/runtime/ResultSetEnumerable.java#L110
I'm not sure I have a small reproducer yet. The checker prints extremely long message before it crashes:
Stacktrace:
The text was updated successfully, but these errors were encountered: