404 on home page if public directory exists in the root of the project

[myshov]

If there is public directory in the root of the project then json-server attempts to serve index.html from there, as result the home page is not working.

Steps for reproduction of the bug:

1. install json-server into fresh npm project
2. create public directory in the root of this new project
3. create db.json
4. start npx json-server db.json
5. check http://localhost:3000/

Expected behavior: home page should work
Actual behavior: home page doesn't work (404 error)

[myshov]

One possible fix is to delete default static fallback into public directory and suggest users always use --static option for serving static files.

Here is part of the code that cause this issue:

json-server/src/server/defaults.js

Lines 11 to 15 in 622400f

	const userDir = path.join(process.cwd(), 'public')
	const defaultDir = path.join(__dirname, '../../public')
	const staticDir = fs.existsSync(userDir) ? userDir : defaultDir
	opts = Object.assign({ logger: true, static: staticDir }, opts)

[myshov]

@typicode hi! What do you think about removing default public fallback?

[myshov]

I figured the better solution is to separate creation of users static server from static server that is used for serving json-server related stuff.

[leandrogehlen]

My solution :

const fs = require('fs');
const path = require('path');
const server = require('json-server');
const routes = require('./routes');

const app = server.create();
const middlewares = server.defaults({
  static: path.join(__dirname, '../node_modules/json-server/public')
});

[afronorana]

My solution :

const fs = require('fs');
const path = require('path');
const server = require('json-server');
const routes = require('./routes');

const app = server.create();
const middlewares = server.defaults({
  static: path.join(__dirname, '../node_modules/json-server/public')
});

Or in my case, I added the static route on the config file json-server.json;

{
    "port": 3000,
    "static": "'./node_modules/json-server/public'"
}

[PLQin]

When I change the static ,

the page that json-server opens no longer shows' You're running JSON Server , but instead becomes a blank page .

Why is that ?