Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Fail to block non-direct adressed elements #1810

Closed
Dushess opened this issue Jun 25, 2019 · 18 comments
Closed

Fail to block non-direct adressed elements #1810

Dushess opened this issue Jun 25, 2019 · 18 comments

Comments

@Dushess
Copy link

Dushess commented Jun 25, 2019

Started not so long time ago, latest Chrome (actually detected on some early platform, like 74 at latest builds)
It looks like your rules about blocking of page elements simply don't work, unless it's an image.

@Dushess
Copy link
Author

Dushess commented Jun 25, 2019

tested with ###somename sitekeys

@uBlockAdmin
Copy link
Collaborator

Thanks for reporting an issue. sitekey is not supported. Can you give me a specific use case to help me replicate the issue?

@Dushess
Copy link
Author

Dushess commented Jun 26, 2019

www.reddit.com###header-bottom-left > .tabmenu > li:nth-of-type(3) > .choice[href="https://www.reddit.com/new/"]

an example
actually it means more than half potential of this tool is missing (also text ads, which is same elements, marked by sitekeys)

@uBlockAdmin
Copy link
Collaborator

I am unable to find out the element.

Screen Shot 2019-06-27 at 12 17 05 PM

@Dushess
Copy link
Author

Dushess commented Jun 27, 2019

Ok, then this
###sr-header-area > .width-clip > .srdrop.dropdown > .title.selected

2669-15
Basically anything that uses ###

@uBlockAdmin
Copy link
Collaborator

uBlockAdmin commented Jun 28, 2019

It's working for me. Here is a screenshot. Looks like you haven't clicked on create button in pop up on bottom right corner.

Screen Shot 2019-06-28 at 11 11 07 AM

@Dushess
Copy link
Author

Dushess commented Jun 28, 2019

Seems to be my installation related, a little video coming soon.

@Dushess
Copy link
Author

Dushess commented Jun 28, 2019

Basically
bandicam video.zip
image

@Dushess
Copy link
Author

Dushess commented Jun 28, 2019

And yes, i know how to, since using this module long time.

@Dushess Dushess changed the title Fail to block non-picture elements Fail to block non-direct adressed elements Jul 10, 2019
@uBlockAdmin
Copy link
Collaborator

We are able to replicate this issue. This fix will be included in the next version release (in a couple of days). Thank you very much.

@Dushess
Copy link
Author

Dushess commented Jul 25, 2019

Thank you

@Dushess Dushess closed this as completed Jul 25, 2019
@Dushess
Copy link
Author

Dushess commented Jul 25, 2019

But for now only reddit is fixed. Tried for example on DA, blocked logo frame (###deviantart-logo > .mark > svg > .wikistick) - as usual don't work for now.

@Dushess Dushess reopened this Jul 25, 2019
@uBlockAdmin
Copy link
Collaborator

We haven't released build (v0.9.5.19) yet. It is under QA. I think you will get an update early next week.

@uBlockAdmin
Copy link
Collaborator

Hi, Can you please verify it your end if you have received v0.9.5.19 update?

@Dushess
Copy link
Author

Dushess commented Aug 1, 2019

Seems to be site-specific. Will look into it.

@Dushess
Copy link
Author

Dushess commented Aug 3, 2019

Not working again, same reddit, just noticed. Some sited are good, some - still do not work. Maybe better switch to Origin, there it's fine....

@Dushess
Copy link
Author

Dushess commented Aug 30, 2019

Browser related, it just sorta broken now. Gonna reinstall, probably NOT use chrome

@uBlockAdmin
Copy link
Collaborator

Thanks for your valuable inputs. There is a lot of area of improvement in Element picker. We will target it in the near future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants