Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slant.co #7950

Closed
ghost opened this issue Sep 25, 2020 · 18 comments
Closed

slant.co #7950

ghost opened this issue Sep 25, 2020 · 18 comments

Comments

@ghost
Copy link

ghost commented Sep 25, 2020

URL(s) where the issue occurs

https://www.slant.co/topics/5335/~alternatives-to-github-for-open-source-projects#1

Describe the issue

Buttons "Free/Paid" have event listener with "mousedown" button.

Normal click generate badly redirection:

d = `http://go.redirectingat.com/?id=${f.env.SKIM_LINKS_ID}&url=${s}&sref=${o}`, e.currentTarget.href = d), "false" === f.env.USE_AI_URLS && !p.getAttribute("data-no-lustre-popup")) return _.delay(() => new i({
    utmSource: f.view.utmSource,
    utmMedium: f.view.utmMedium,
    utmCampaign: f.view.utmCampaign
}), 1e3)
}
}, d = function(e) {
    return _.defer(function() {
        var t;
        if (t = e.dataset.href) return e.href = t
    })
},

Screenshot(s)

Versions

  • Browser/version: Firefox 81
  • uBlock Origin version: uBO 1.29.2

Settings

stock

Notes

Maybe possible kill redrection? If no maybe needed is allow something like that:

@@||go.redirectingat.com/?*www.slant.co*$doc
@@||go.skimresources.com/?*www.slant.co*$doc

because both blocked by HOSTS Peter Lowe’s Ad and tracking server list.

@okiehsch
Copy link
Contributor

okiehsch commented Sep 25, 2020

You get redirected to the strict block page.
You can get to your destination domain https://github.com/gorhill/uBlock/wiki/Strict-blocking#ability-to-parse-the-strict-blocked-url without issue as far as I can see.
image

@ghost
Copy link
Author

ghost commented Sep 25, 2020

So use tab button and enter button, when redirect no exist.

Mousedown event fail when use keyboard to open links, maybe touch screen monitor is good workaround, but who sell me for free?

@okiehsch
Copy link
Contributor

I don't understand what you want to tell me.
If someone has a working filter to disable the redirection without exception filters we will add them.
My comment was meant to clarify that the blocked page you see is by design.

@uBlock-user
Copy link
Contributor

test slant.co##+js(ra, target|rel, .GetItHereButton-Price)

@ghost
Copy link
Author

ghost commented Sep 25, 2020

No works.

@ghost ghost closed this as completed Sep 25, 2020
@uBlock-user uBlock-user reopened this Sep 25, 2020
@ghost ghost closed this as completed Sep 25, 2020
@mapx-
Copy link
Contributor

mapx- commented Sep 25, 2020

We could badfilter such filters

||redirectingat.com^$badfilter
||skimresources.com^$badfilter

@okiehsch
Copy link
Contributor

Why? It's by design behaviour.

@uBlock-user
Copy link
Contributor

slant.co##+js(ra, target|rel, a[itemprop="url"][data-href]) works for me.

@okiehsch
Copy link
Contributor

Does not work on my end. Tried with Chromium and Firefox.

@mapx-
Copy link
Contributor

mapx- commented Sep 25, 2020

slant.co##+js(ra, target|rel, a[itemprop="url"][data-href]) works for me.

does not work, strict blocking again

@mapx-
Copy link
Contributor

mapx- commented Sep 25, 2020

Why? It's by design behaviour.

I mean skimresources seems legit stuff, nothing malicious

@uBlock-user
Copy link
Contributor

Race condition perhaps, user could just right click on the button and open in a new tab.

@lain566
Copy link
Contributor

lain566 commented Sep 25, 2020

Something like this might help too
uBlockOrigin/uBlock-issues#760

@okiehsch
Copy link
Contributor

"Redirections.skimresources.com
If you've landed on this page, you may be wondering exactly what it's all about. We're Skimlinks — a service that helps online publishers earn money."

Don't we always strict block such services to make the user aware that they have clicked a tracking link?
@gorhill

@okiehsch
Copy link
Contributor

okiehsch commented Sep 25, 2020

slant.co##+js(aeld) works but, well that's a little bit broad.

@uBlock-user
Copy link
Contributor

slant.co##+js(aeld, mousedown) a bit less broad ?

@okiehsch
Copy link
Contributor

Yes much better but that could still break stuff.

@okiehsch okiehsch reopened this Sep 25, 2020
@gorhill
Copy link
Member

gorhill commented Sep 25, 2020

Don't we always strict block such services to make the user aware that they have clicked a tracking link?

Yes, these hostnames are in Peter Lowe's and I rather not second guess why they are there, this is the kind of stuff we want to enforce, and especially in the current case it reveals the tracking.

It's just fine to not fix this case, bringing forth the redirection to the user attention is by-design, and when redirection occurs, users are free to bypass the redirection using the information given to them in the document-blocked page through the URL-parsing feature.

To me, all work as expected. If people find the strict-blocking inconvenient, then they have the choice to ignore it or they can create their own exception filters as OP suggest -- we are not going to apply someone preference in how to deal with this to all other users.

@ghost ghost closed this as completed Sep 25, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants