Replies: 3 comments 2 replies
-
Any opinion @gorhill? Is there a way to enable theme-based images in the wiki or should I just add them side by side, like in my README suggestion patch? |
Beta Was this translation helpful? Give feedback.
-
We should stick to light theme by default for consistency. We can update images for when there are new features present in current versions of uBO. We want to document functionality, not appearance -- which is just pixels colored a different way. |
Beta Was this translation helpful? Give feedback.
-
The light theme version is still shown in your changes. I don't mind pulling in your changes for the popup panel, my point is that we shouldn't extend everywhere showing two versions of the user interface every time we document features. |
Beta Was this translation helpful? Give feedback.
-
There's quite a bit of outdated images across the wiki. I'm proposing updating them and serving a 2nd (dark theme) option as well.
There's no hurry, so I can take it upon myself, if needed.
As per docs it should be possible to use github theme-based variants. Unfortunately, when I tried using it on the draft wiki, it didn't seem to work when previewing. (Working fine when testing on a new page on a fork.)
I'm not sure if this requires toggling some setting in the project.
For the time being the theme-based images aren't yet supported in the README, but the issue about this has already moved to the backlog so it will be fixed at some point.
For now, I'm proposing: gorhill/uBlock@master...u-RraaLL:patch-1
Beta Was this translation helpful? Give feedback.
All reactions