Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic Exception filter disabling? #1322

Closed
8 tasks done
nick-n-dev opened this issue Nov 4, 2020 · 16 comments
Closed
8 tasks done

Cosmetic Exception filter disabling? #1322

nick-n-dev opened this issue Nov 4, 2020 · 16 comments
Labels
duplicate This issue or pull request already exists

Comments

@nick-n-dev
Copy link

nick-n-dev commented Nov 4, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

I am aware of important/badfilter etc for static filters, however none of that seems to apply to cosmetic filters.

As an example: a 3rd party filters list adds an exception rule of the form '#@##'
Now there seems to be nothing i can do on my side to disable/override that, adding the same rule without '@' has no effect.
Obviously dynamic filtering is not an option.

I believe anything in "My Filters" should trump EVERYTHING else, otherwise its purpose is somewhat...limited.

A specific URL where the issue occurs

n/a

Steps to Reproduce

n/a

Expected behavior:

Exception in 3rd party list is ignored/overriden by locally defined filter.

Actual behavior:

Locally defined filter is overriden by 3rd party.

Your environment

  • uBlock Origin version: 1.30.6
  • Browser Name and version: Firefox ESR 78.4.0
  • Operating System and version: Winblows 10
@uBlock-user
Copy link
Contributor

then append a invalid element token such as important after the element. eg ##[selector],important

@uBlock-user uBlock-user added the invalid not a uBlock issue label Nov 4, 2020
@nick-n-dev
Copy link
Author

then append a invalid element token such as important after the element. eg ##[selector],important

Could you please clarify what you mean? i have already tried adding ,important after the element, and it changed nothing.

@uBlock-user
Copy link
Contributor

Exception in 3rd party list is ignored/overriden by locally defined filter.

Post a specific example, the vague description does not help.

@nick-n-dev
Copy link
Author

nick-n-dev commented Nov 4, 2020

Ok, so:

say a 3rd party filterlist (adguard/easylist for example) have a filter such as: somewebsite.com#@##subscribe-button in their list.

But i dont want to actually see that element, so i go to my filters, and i add: somewebsite.com###subscribe-button

Nothing changes, and the log shows it's still being filtered, i tried: somewebsite.com###subscribe-button,important
but that also did nothing.

I hope that's clear enough :)
I would really prefer not to have to disable a whole list (and a pretty important one to me) just for 1 line...

@uBlock-user
Copy link
Contributor

i tried: somewebsite.com###subscribe-button,important
but that also did nothing.

What did the logger show this time ? and post the filter which was shown here.

@nick-n-dev
Copy link
Author

nick-n-dev commented Nov 4, 2020

Not sure what i should copy/paste so i'll just stick a couple screenshots here:

Logger:
screen1
screen2

What it looks like in "My Filters"
screen3

@uBlock-user
Copy link
Contributor

As per the second screenshot, your filter is getting applied and I just tested this on my setup with Fanboy Annoyance/Social activated on a youtube channel and it works as expected.

youtube.com###subscribe-button,important helps bypass the exception(#@##) filter and successfully hides the Subscribe button for e.g https://www.youtube.com/channel/UCPD_bxCRGpmmeQcbe2kpPaA

Make sure all other extensions are disabled when you're testing.

@nick-n-dev
Copy link
Author

You're right,
not sure what was causing the button to stay (it does seem to be working after refreshing firefox).
I just saw the yellow-highlighted entry in the log and assumed the local filter was being ignored, my bad.

Thank you for the help though, very much appreciated.

@uBlock-user
Copy link
Contributor

uBlock-user commented Nov 4, 2020

not sure what was causing the button to stay

This doesn't happen if you added ###subscribe-button,important via Picker. Anyways, next time provide full Steps To Reproduce and if you can't do that, then post the issue on reddit, which is the dedicated help section, while GitHub is only for provable issues with details Steps To Reproduce along with filling the entire template as asked.

@krystian3w
Copy link

krystian3w commented Nov 4, 2020

To enforce disabled filter via #@# try:

youtube.com###subscribe-button#subscribe-button


Idea with add ,important to comsetic filters can misleading this (for network filters):

https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#important
https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#badfilter

The chance of a html element:

<important> 
    blah blah blah blah 
</important>

being present in the Internet is probably close to zero.

@uBlock-user
Copy link
Contributor

Duplicate of #388

@uBlock-user uBlock-user marked this as a duplicate of #388 Nov 4, 2020
@uBlock-user uBlock-user added duplicate This issue or pull request already exists and removed invalid not a uBlock issue labels Nov 4, 2020
@u-RraaLL
Copy link
Contributor

I've encountered a similiar issue, I've found and added a third-party filter list which has turned out to contain several bad/unwanted cosmetic generic filters which break some sites: ##.ads, ##div[class*="ads"]. Now, there seems to be no way to disable ##.ads without disabling similiar filters on other filter lists (for example EasyList)

Isn't that what ghide is for?

@gorhill
Copy link
Member

gorhill commented Nov 24, 2021

Well if a list contains "several bad/unwanted cosmetic generic filters" causing you issue, then it's a low quality list which you should not subscribe to -- that's the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants
@gorhill @uBlock-user @krystian3w @nick-n-dev @u-RraaLL and others