Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock issue 3708: "uBlock Origin translation" #2

Closed
gorhill opened this issue Apr 16, 2018 · 10 comments
Closed

uBlock issue 3708: "uBlock Origin translation" #2

gorhill opened this issue Apr 16, 2018 · 10 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@gorhill
Copy link
Member

gorhill commented Apr 16, 2018

Continuation of gorhill/uBlock#3708.

@joey04
Copy link

joey04 commented Apr 16, 2018

In response to your concern there about "uAssets" not being translatable, I don't see why that would be a concern. Consider that filter-syntax is essentially English-based to begin with and if they find a filter issue they'll need to report it in English on the tracker here. So why would the "uAssets" label be a problem?

@overdodactyl
Copy link

It's worth considering that the average user never looks into filter syntax or reports issues. The main use of that interface is for users to select what filters they want to go into effect. Being able to understand the category headers and filter titles is an important step in selecting your lists.

@joey04
Copy link

joey04 commented Apr 16, 2018

That's a good point about the purpose of the Filters list panel. But keep in mind that the list names themselves are still predominantly English words. So it's practically unavoidable for a user to select lists without some understanding of English.

As for the specific topic of the section header label, looking at both the current Japanese and Chinese locale files, the extName field is "uBlock Origin" in one and "uBlock₀" in the other.

Since non-English-speakers will already see one of these labels, it may be best to name the section header with one of those rather than introducing yet another English label of "uAssets".

Given this status quo, I'd say "uBlock₀" is the better choice as section header because it's shorter.

@overdodactyl
Copy link

But keep in mind that the list names themselves are still predominantly English words. So it's practically unavoidable for a user to select lists without some understanding of English.

Unless I'm mistaken, I believe the list names have translations. For example:

https://github.com/gorhill/uBlock/blob/daf762d56a92459776a3b5a1e09bd213785a44dc/src/_locales/ja/messages.json#L358-L369

@overdodactyl
Copy link

The idea is more like "Homegrown" filter lists -- as in "these lists are maintained by uBO", and I ended up using "Local" because that's what seemed least worse in listed synonyms.

Maybe something like "uBO Affiliated"?

@BilBg
Copy link

BilBg commented Apr 16, 2018

Some icons after the name with appropriate info/link (e.g. Who makes these lists / Where these lists come from / What every list is for...) may also help.

uBlock Origin's set of lists (?) (i)

@joey04
Copy link

joey04 commented Apr 16, 2018

Unless I'm mistaken, I believe the list names have translations.

I was unaware of that. But it only applies to uAssets lists, right? EasyList and many others will still be English-only names. So my point still mainly applies.

@overdodactyl
Copy link

@joey04, on second look, I may have been mistaken. The code I linked to was the translations for headers, not the actual lists themselves.

@vlaszlo
Copy link

vlaszlo commented Apr 17, 2018

How about "Internal" or "Built-In" with a tooltip or an information icon that explains (or links to an explanation) that these lists are maintained by the author of uBlock Origin, but can be updated independently from the extension for efficiency?

@gorhill
Copy link
Member Author

gorhill commented Apr 18, 2018

I will go with "Built-in": they are both part of the package and maintained by uBO (EasyList, EasyPrivacy etc. are part of the package but not maintained by uBO). It's translatable. I don't think any explanation is required. This is currently what is holding me from publishing the current version, so this will allow me to go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

6 participants