-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental procedural cosmetic operator :others()
prevents Firefox Screenshots
#2099
Comments
There is possibly related a Mozilla Bugzilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=1696573, but according to https://bugzilla.mozilla.org/show_bug.cgi?id=1763548#c4
|
You forgot about selection and preview iframes. Also I don't recommend repair this by |
Thanks.
My intended workaround is the following filter. |
The only way to "fix" this is by removing the operator. Is this what people want? |
At least I don't want that since I use it on Twitter. |
Not possible, the DOM is shared by all: Firefox's own tools, other extensions, the site itself. It's just not possible for uBO to make hard-coded guesses about what should not be removed based only on DOM information. In the current case, adding
|
Prerequisites
I tried to reproduce the issue when...
Description
Cosmetic filters using
:others()
introduced by gorhill/uBlock@152120b crafted without the countermeasures interfere with Firefox Screenshots.It may be by design, and the workaround is easy for the filter authors. However, Firefox Screenshots is a built-in add-on enabled by default, so it might be more user-friendly to handle Firefox Screenshots iframes by uBlock Origin itself in advance.
A specific URL where the issue occurs
https://www.nature.com/articles/d41586-022-00567-9
Steps to Reproduce
nature.com##:matches-path(/^/articles//) :is(.c-breadcrumbs,.c-article-main-column):others()
to My filtershttps://www.nature.com/articles/d41586-022-00567-9
Expected behavior
Firefox Screenshot starts.
Actual behavior
Nothing happens.
Configuration
The text was updated successfully, but these errors were encountered: