Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checking "Enable my custom filters" with no sources causes CPU usage to throttle #3481

Open
9 tasks done
Tavanator opened this issue Dec 11, 2024 · 8 comments
Open
9 tasks done
Labels
unable to reproduce cannot reproduce the issue

Comments

@Tavanator
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

When selecting "enable my custom filters" without any sources in the filter list, Firefox begins throttling CPU on websites.

A specific URL where the issue occurs.

*any website in which you visit has some slowness and stuttering

Steps to Reproduce

  1. Open UBlock extension
  2. Select "settings" cogs at the bottom right of the window
  3. navigate to "My Filters"
  4. Check "enable my custom filters"
  5. Do not add any sources in the list

Expected behavior

The expected outcome should be performance issues within the browser, including the cursor disappearing when going over the browser, the webpage "lagging" behind when scrolling.

Actual behavior

Web pages freeze for an unexpected amount of time before resuming.

uBO version

uBlock Origin 1.61.2

Browser name and version

Firefox 133.0 (64-bit)

Operating System and version

Windows 11 version 23H2

@gwarser
Copy link

gwarser commented Dec 11, 2024

https://github.com/uBlockOrigin/uBlock-issues?tab=readme-ov-file#performance-issues

@gorhill
Copy link
Member

gorhill commented Dec 12, 2024

  • using a new, unmodified browser profile.

That setting is checked by default in a new install, and there are no custom filters by default. What exact steps did you perform in that new profile to trigger the issue?

@gorhill gorhill added the unable to reproduce cannot reproduce the issue label Dec 12, 2024
@Tavanator
Copy link
Author

  • using a new, unmodified browser profile.

That setting is checked by default in a new install, and there are no custom filters by default. What exact steps did you perform in that new profile to trigger the issue?

I added a source for testing but removed it. I did have the capture but unfortunately did not export it. I don't want to waste anyone's time on this but figured in the event someone encountered the same issue, there would be a starting point if it happened again. I will continue to test in my dev environment with exported captures.

@gorhill
Copy link
Member

gorhill commented Dec 12, 2024

Do not add any sources in the list

I added a source for testing but removed it.

What do you mean by "source"? The "My filters" pane is a place to add filters -- I don't understand what you mean by "add any sources".

@Tavanator
Copy link
Author

Do not add any sources in the list

I added a source for testing but removed it.

What do you mean by "source"? The "My filters" pane is a place to add filters -- I don't understand what you mean by "add any sources".

A filter? Domain?

@gorhill
Copy link
Member

gorhill commented Dec 12, 2024

Please confirm again: did you really reproduce in a new browser profile with only uBO installed with no changes? If so, since the option "Enable my custom filters" is enabled by default, how did you reproduce? You un-checked the option then checked again?

@Tavanator
Copy link
Author

Please confirm again: did you really reproduce in a new browser profile with only uBO installed with no changes? If so, since the option "Enable my custom filters" is enabled by default, how did you reproduce? You un-checked the option then checked again?

Correct. I added a filter/domain to the filters field, removed it and saw performance issues. Once I unchecked it and checked it again, the performance issues went away.

@MasterKia
Copy link
Member

What filter/domain did you exactly add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unable to reproduce cannot reproduce the issue
Projects
None yet
Development

No branches or pull requests

4 participants